feat(attributes): Add browser.bfcache.* attributes - #513
Open
logaretm wants to merge 3 commits into
Open
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧Attribute
Attributes
Deps
Other
🤖 This preview updates automatically when you update the PR. |
Registers the four attributes emitted by the new bfcacheMetricsIntegration in the JS SDK: browser.bfcache.outcome, browser.bfcache.reason, browser.bfcache.frame, and browser.bfcache.not_restored_reason_count. All are Sentry-specific (not in OTel).
The SDK frames reasons purely by position; 'masked' is a reason value, not a frame, so drop it (and 'unknown') from the frame attribute.
logaretm
force-pushed
the
feat/bfcache-attributes
branch
from
July 23, 2026 16:55
4074543 to
03cc94e
Compare
logaretm
marked this pull request as ready for review
July 23, 2026 17:07
logaretm
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
July 23, 2026 17:07
Lms24
reviewed
Jul 24, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
The attribute names look very reasonable to me, so no objections to adding them from my end! We should adjust the apply_scrubbing behaviour though (see comment).
| "brief": "Which frame in the page's frame tree a back/forward cache not-restored reason originated from: the top document or a child frame.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "never" |
Member
There was a problem hiding this comment.
Suggested change
| "key": "never" | |
| "key": "manual" |
I 100% agree that Pii isnt a concern here but we should only set never if product functionality would break if the attribute value got scrubbed. Which I think isn't the case. It would break created BF-cache dashboards but users would have to do their part for this to happen. So I'd suggest we set "manual". Meaning if users configure this field to be scrubbed (for whatever reason) it will be scrubbed. Otherwise, it will be left as-is. More details: https://develop.sentry.dev/engineering-practices/sentry-conventions/#before-opening-a-pr
Member
Author
There was a problem hiding this comment.
Ah okay, thanks for the clarification!
Lms24
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers the four
browser.bfcache.*attributes emitted by the newbfcacheMetricsIntegrationin the JS SDK (getsentry/sentry-javascript#22397).They describe browser back/forward-cache health metrics.
browser.bfcache.outcomehit/missof a back/forward navigation.browser.bfcache.reasonnotRestoredReasons).browser.bfcache.frametop/child).browser.bfcache.not_restored_reason_count0when the browser reported none, e.g. non-Chromium).All are Sentry-specific, so
is_in_otel: falseand PII is not applicable here.